Skip to content

FOUR-9362 Log error and continue running if settings are not set#5029

Merged
ryancooley merged 7 commits into
developfrom
feature/FOUR-9362
Jul 21, 2023
Merged

FOUR-9362 Log error and continue running if settings are not set#5029
ryancooley merged 7 commits into
developfrom
feature/FOUR-9362

Conversation

@nolanpro
Copy link
Copy Markdown
Contributor

@nolanpro nolanpro commented Jul 20, 2023

Issue & Reproduction Steps

A process errors when run and some settings are not set for scripts and data sources

Solution

Continue running a process if some script or data connector settings are not set. Log the error in the data object

How to Test

Create a process and drag a script and data connector node onto the canvas. Do not configure the nodes. Connect them and run the process. The process should complete without errors.

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:package-data-sources:feature/FOUR-9362

@nolanpro nolanpro changed the title Feature/four 9362 FOUR-9362 Log error and continue running if settings are not set Jul 20, 2023
@nolanpro nolanpro requested a review from eiresendez July 20, 2023 00:45
@nolanpro nolanpro requested review from gproly and removed request for eiresendez July 20, 2023 18:42
@processmaker-sonarqube
Copy link
Copy Markdown

SonarQube Quality Gate

Quality Gate failed

Failed condition 8.9% 8.86% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

@ryancooley ryancooley merged commit b58bcae into develop Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants